Skip to content

Filter by Git Status & Responsive fixes#668

Open
mdo wants to merge 7 commits into
mainfrom
mdo/diffshub-git-status
Open

Filter by Git Status & Responsive fixes#668
mdo wants to merge 7 commits into
mainfrom
mdo/diffshub-git-status

Conversation

@mdo

@mdo mdo commented May 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffs Ready Ready Preview Jun 12, 2026 8:56pm
pierre-docs-diffshub Ready Ready Preview Jun 12, 2026 8:56pm
pierre-docs-trees Ready Ready Preview Jun 12, 2026 8:56pm
pierrejs-diff-demo Ready Ready Preview Jun 12, 2026 8:56pm
pierrejs-docs Ready Ready Preview Jun 12, 2026 8:56pm

Request Review

@mdo mdo changed the base branch from main to beta-1.2 May 12, 2026 03:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 12, 2026

Copy link
Copy Markdown

💡 Codex Review

pierre/packages/diffs/src/components/CodeView.ts

Line 656 in 92e5e3f

window.__INSTANCE = this;

P2 Badge Remove global debug hooks from CodeView setup

Avoid assigning window.__INSTANCE/window.__TOGGLE during normal setup() because these hooks run in all builds and keep a strong reference to the viewer instance after mount. In long-lived docs sessions (or repeated mounts/unmounts), this can leak memory and also lets unrelated page scripts mutate the active viewer state through those globals.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mdo mdo changed the title Filter by Git Status Filter by Git Status & Responsive fixes May 12, 2026
@amadeus amadeus force-pushed the beta-1.2 branch 2 times, most recently from 64bc6a1 to 201f0ba Compare May 16, 2026 00:04
@mdo mdo force-pushed the mdo/diffshub-git-status branch from 872a241 to d36198e Compare May 20, 2026 05:26
Base automatically changed from beta-1.2 to main May 20, 2026 18:43
@amadeus

amadeus commented Jun 10, 2026

Copy link
Copy Markdown
Member

@mdo do we still want to get this merged?

@mdo mdo force-pushed the mdo/diffshub-git-status branch from d36198e to edfd212 Compare June 12, 2026 05:06
@mdo

mdo commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@mdo do we still want to get this merged?

@amadeus I just rebased might, need to clean up more. After that I think I still need to play with a little of the UI and logic here to feel out if the flow is right. Last we talked, we maybe discussed reversing the behavior of the menu items there now. Curious to see what @necolas thinks if he has time to look though too.

@necolas

necolas commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

The git status popover doesn't match the active shiki theme.
My initial thought upon seeing the tick mark over the status symbol was that it was bugged

image

wonder if it might be better to put the check state symbol on the right like it is on the themes popover

image

@mdo

mdo commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Ya that's a bug from the rebase. It'd be on the right. I can also look into how to match it's theme, too.

@mdo mdo force-pushed the mdo/diffshub-git-status branch from edfd212 to 531bdc0 Compare June 12, 2026 20:54
necolas
necolas approved these changes Jun 12, 2026
View reviewed changes

@necolas necolas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These icons dont have hover/focus states for light themes

Image

Happy for this to be merged though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amadeus amadeus amadeus approved these changes

@necolas necolas necolas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdo @amadeus @necolas